add GraphQL documentation (except computation) #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs can be seen in GraphQL Playground (/_api/graphql) in the Docs drawer. Just go visit the queries and mutations and u can see the related types and enums
|
saengowp
reviewed
Aug 20, 2022
| @@ -32,6 +32,13 @@ export class ReviewService { | |||
| { courseNo, semester, academicYear, studyProgram, rating, content }: CreateReviewInput, | |||
| userId: string | |||
| ): Promise<Review> { | |||
| if (rating) { | |||
There was a problem hiding this comment.
I don't get this line. How does the bound check work?
There was a problem hiding this comment.
I derped. This is supposed to be if (rating < 0 || rating > 10)
Same as below
| if (reviewInput.rating) { | ||
| throw new BadRequestException({ | ||
| reason: 'RATING_OUT_OF_BOUND', | ||
| message: `Rating must be between 0 and 10. Got ${reviewInput.rating}`, |
There was a problem hiding this comment.
See above, What are the example output?
| courseCart: [CourseCartItem!] | ||
| calendarId: String | ||
|
|
||
| calendarId: String @deprecated(reason: "Will be redesigned.") |
There was a problem hiding this comment.
Im not sure if frontend currently accesses it or not. If not, then we can just remove.
saenyakorn
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why did you create this PR
What did you do
Demo
https://dev.cugetreg.com
Checklist