-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tonnam/feat(v2)/expaned course card dialog #737
base: v2
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer Runes Mode for new code. If not conflict with bits-ui, please change to Runes Mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expanded course card looks good for me
<script lang="ts"> | ||
import { cn } from '../../../../../utils' | ||
import { Chip } from '../chip' | ||
import { chipVariants, type Status } from './index.js' | ||
|
||
let className: string | undefined | null = undefined | ||
export let status: Status | ||
export let closable: boolean = false | ||
export let onClose: () => void = () => {} | ||
export { className as class } | ||
</script> | ||
|
||
<Chip class={cn(chipVariants({ status, className }))} {closable} {onClose}> | ||
{#if status == 'close'} | ||
ปิด | ||
{:else} | ||
<slot /> | ||
{/if} | ||
</Chip> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this component should accept registered and max seat instead of slot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status
can be removed as it can be inferred from closed, regis, max
import { SeatChip } from './index.js' | ||
|
||
const { Story } = defineMeta<typeof SeatChip>({ | ||
title: 'Atom/SeatChip', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add space in Title
title: 'Atom/SeatChip', | |
title: 'Atom/Seat Chip', |
Why did you create this PR
What did you do
SeatChip
component and integrated it into expanded course card.ExpandedCourseCardDialog
for course detail.SeatChip
andExpandedCourseCardDialog
.ExpandedCourseCardDialog
and moved it toMolecule
components.**