Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tonnam/feat(v2)/expaned course card dialog #737

Open
wants to merge 17 commits into
base: v2
Choose a base branch
from

Conversation

phongit-kha
Copy link
Member

Why did you create this PR

  • add expanded course card dialog component

What did you do

  • Added SeatChip component and integrated it into expanded course card.
  • Implemented ExpandedCourseCardDialog for course detail.
  • Created Storybook examples for SeatChip and ExpandedCourseCardDialog.
  • Updated button and table styles for consistency.
  • Refactored ExpandedCourseCardDialog and moved it to Molecule components.**

Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 521b6f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@leomotors leomotors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer Runes Mode for new code. If not conflict with bits-ui, please change to Runes Mode.

Copy link
Member

@leomotors leomotors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expanded course card looks good for me

Comment on lines +1 to +19
<script lang="ts">
import { cn } from '../../../../../utils'
import { Chip } from '../chip'
import { chipVariants, type Status } from './index.js'

let className: string | undefined | null = undefined
export let status: Status
export let closable: boolean = false
export let onClose: () => void = () => {}
export { className as class }
</script>

<Chip class={cn(chipVariants({ status, className }))} {closable} {onClose}>
{#if status == 'close'}
ปิด
{:else}
<slot />
{/if}
</Chip>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this component should accept registered and max seat instead of slot

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status can be removed as it can be inferred from closed, regis, max

import { SeatChip } from './index.js'

const { Story } = defineMeta<typeof SeatChip>({
title: 'Atom/SeatChip',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add space in Title

Suggested change
title: 'Atom/SeatChip',
title: 'Atom/Seat Chip',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants