Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ableton link as submodule #1119

Merged
merged 4 commits into from
Jan 28, 2025
Merged

ableton link as submodule #1119

merged 4 commits into from
Jan 28, 2025

Conversation

sss-create
Copy link
Collaborator

Almost successfully replaced the integrated link code with a submodule.
However, the Nix builds fail. Maybe @mitchmindtree can help out again?

@yaxu
Copy link
Member

yaxu commented Jan 24, 2025

@sss-create
Copy link
Collaborator Author

I did not get it to work with the info from the link..

@yaxu
Copy link
Member

yaxu commented Jan 25, 2025

Erp sorry, maybe this is related.. #924

@yaxu
Copy link
Member

yaxu commented Jan 25, 2025

(can't see why, just a similar error ..)

@sss-create
Copy link
Collaborator Author

Hm, not sure. Everything but Nix works. Nix flakes are not best friends with submodules it seems:
NixOS/nix#4423
NixOS/nix#6633

@yaxu yaxu force-pushed the dev branch 2 times, most recently from 05123c5 to eab7f2d Compare January 28, 2025 07:34
@chreekat
Copy link

According to the info in that first link, try adding ?submodules=1 to the nix build invocation at https://github.com/tidalcycles/Tidal/blob/dev/.github/workflows/nix.yml#L41

@sss-create
Copy link
Collaborator Author

sss-create commented Jan 28, 2025

This drives me crazy 🥲

Local Nix builds work. CI does not.

@sss-create
Copy link
Collaborator Author

Finally, this thread held the solution: NixOS/nix#9530 (comment)
The solution is to use: '?submodules=1#default'

@yaxu, this can be merged now, if you'd be so kind and give your go :)
one more thing; we should probably add an info on how to checkout submodules in the readme, such as ableton link does:

Link relies on asio-standalone as a submodule. After checking out the main repositories, those submodules have to be loaded using git submodule update --init --recursive

@sss-create sss-create marked this pull request as ready for review January 28, 2025 20:22
@yaxu yaxu merged commit 1206820 into tidalcycles:dev Jan 28, 2025
18 checks passed
@yaxu
Copy link
Member

yaxu commented Jan 28, 2025

Thanks for seeing this through!

@yaxu
Copy link
Member

yaxu commented Jan 28, 2025

I added a submodule note to CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants