-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-24822] Fix TableView issue on Android N #9144
Conversation
// TIMOB-24560: prevent duplicate TableViewRowProxyItem on Android N | ||
if (Build.VERSION.SDK_INT > 23) { | ||
ArrayList<Item> models = viewModel.getViewModel(); | ||
if (models.contains(v.getRowData())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should check if "models" is null before using it.
It can be null if TableViewModel.release() gets called.
The rest looks fine. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
FR Passed - 1st Test case no longer crashed and 2nd test case returned the correct index positions. Test Steps
Test Environment |
TEST CASE #1
TEST CASE #2
JIRA Ticket