Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the tz and date headers from clock rather than localtime.c #321

Closed
wants to merge 1 commit into from

Conversation

jimhester
Copy link
Collaborator

@DavisVaughan How do you envision packages using the tz library from clock? Because the code I use here uses local_days, which is defined in the non-header only tz I need to include tz.cpp in my code.

This works 'as-is' on my local macOS machine (and likely linux) using the OS supplied timezone databases, however it won't work on windows.

Are packages supposed to use your tzdb package and then set the timezone database to that in their .onLoad() or is there another way to go about this? Ideally without calling into R functions in clock from C++?

@jimhester
Copy link
Collaborator Author

Closed in favor of #322

@jimhester jimhester closed this Apr 13, 2021
@jimhester jimhester deleted the clock branch November 23, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant