Use the tz and date headers from clock rather than localtime.c #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DavisVaughan How do you envision packages using the tz library from clock? Because the code I use here uses
local_days
, which is defined in the non-header only tz I need to includetz.cpp
in my code.This works 'as-is' on my local macOS machine (and likely linux) using the OS supplied timezone databases, however it won't work on windows.
Are packages supposed to use your tzdb package and then set the timezone database to that in their
.onLoad()
or is there another way to go about this? Ideally without calling into R functions in clock from C++?