This repository has been archived by the owner on Aug 12, 2021. It is now read-only.
User Profile with Conference List #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new user profile page that lists the user's upcoming and past conferences, allowing other users to browse conferences and easily introduce themselves with a button linking to the existing "Introduce yourself" link. Adds a settings panel to allow the logged in user to turn on or off their public conference list. Allows users to add a URL to a conference when creating, and changes conf badges to include a link to the conference page. Adds tests for features mentioned above.
Nitpick-CI
reviewed
Mar 3, 2017
| use Illuminate\Database\Migrations\Migration; | ||
| use Illuminate\Database\Schema\Blueprint; | ||
|
|
||
| class AddDetailsToUsersTable extends Migration |
There was a problem hiding this comment.
Each class must be in a namespace of at least one level (a top-level vendor name)
Nitpick-CI
reviewed
Mar 3, 2017
| use Illuminate\Database\Migrations\Migration; | ||
| use Illuminate\Database\Schema\Blueprint; | ||
|
|
||
| class AddConfUrlToConferencesTable extends Migration |
There was a problem hiding this comment.
Each class must be in a namespace of at least one level (a top-level vendor name)
|
@orediggerco awesome, will take a look at it as soon as i can -- thanks for the PR! |
|
@orediggerco Thanks again for this! Reason I haven't merged yet is because we're considering a pretty big refactor of how conferences work, and this might actually complicate that further. I'll merge it if we end up keeping conferences the same--and either way, thank you for your work! |
|
No problem at all! Would love to help out with the refactor, if there's anything I can contribute. Regardless, thanks for taking a look! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Matt, Michael,
First, sorry about the duplicate PR. Had to recreate when I noticed that my author/committer data was wrong. 🙃
This PR includes some new functionality that is somewhat related to some of the open issues, but not directly. It creates an internal (auth-guarded) User Profile page that would list all of the user's upcoming and past conferences. For upcoming conferences, it lets the user easily Introduce themselves using the existing "Introduce" functionality.
Importantly, this change does allow each user to choose whether or not they want their conferences to be shown publicly. If turned off (the default), any other user that tries to view their conferences will just receive a generic "This user hasn't added any conferences yet" message. Also, users cannot view the list of friends for a conference. The conference owner is still the only person who can view their friends.
I also added a field for a Conference URL when creating a new conference, and made the conference name on the "badges" to be links to the URL, if present.
Settings Page
Note: I haven't added the search functionality yet, but added the support in settings
Profile Page
Thanks for your time and consideration! Critiques/change requests welcome :)