pdclient: Add caller info to pd client #1516
Open
+38
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
dco-signoff: yes
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
ti-chi-bot
bot
added
size/M
Signed-off-by: okJiang <[email protected]>
okJiang
force-pushed
the
add-pd-caller
branch
from
2533e17 to
785a707
Compare
ti-chi-bot
bot
added
size/S
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
|
/retest |
1 similar comment
|
/retest |
ti-chi-bot
bot
added
size/M
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
JmPotato
reviewed
Feb 20, 2025
internal/locate/pd_codec.go
Outdated
| @@ -71,7 +72,7 @@ func NewCodecPDClientWithKeyspace(mode apicodec.Mode, client pd.Client, keyspace | |||
| return nil, err | |||
| } | |||
|
|
|||
| return &CodecPDClient{client, codec}, nil | |||
| return &CodecPDClient{client.WithCallerComponent("codec-pd-client"), codec}, nil | |||
There was a problem hiding this comment.
Should we also extract this as a constant to reuse it in line 61?
Signed-off-by: okJiang <[email protected]>
bufferflies
reviewed
Feb 25, 2025
| @@ -285,7 +285,7 @@ func NewKVStore(uuid string, pdClient pd.Client, spkv SafePointKV, tikvclient Cl | |||
| clusterID: pdClient.GetClusterID(context.TODO()), | |||
| uuid: uuid, | |||
| oracle: o, | |||
| pdClient: pdClient, | |||
| pdClient: pdClient.WithCallerComponent("kv-store"), | |||
There was a problem hiding this comment.
How about defining and describing one enum not using string?
There was a problem hiding this comment.
How about defining them in pd repo? If you agree, I can open a pr to do it.
bufferflies
reviewed
Feb 25, 2025
| @@ -64,6 +65,10 @@ type InterceptedPDClient struct { | |||
| pd.Client | |||
| } | |||
|
|
|||
| func NewInterceptedPDClient(client pd.Client) *InterceptedPDClient { | |||
There was a problem hiding this comment.
needs comment for public.
bufferflies
approved these changes
Mar 3, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
bot
added
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref tikv/pd#8593