-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p-dml: resolve locks concurrently #1584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: you06 <[email protected]>
ekexium
approved these changes
Feb 18, 2025
cfzjywxk
approved these changes
Feb 19, 2025
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, ekexium The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
you06
added a commit
to you06/client-go
that referenced
this pull request
Feb 19, 2025
close tikv#1577 Signed-off-by: you06 <[email protected]>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Feb 28, 2025
close #1577 Signed-off-by: you06 <[email protected]>
you06
added a commit
to you06/client-go
that referenced
this pull request
Mar 3, 2025
close tikv#1577 Signed-off-by: you06 <[email protected]>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
close #1577 Signed-off-by: you06 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
dco-signoff: yes
Indicates the PR's author has signed the dco.
lgtm
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1577
The default range task size is too large for p-dml, which makes the concurrent resolve works bad, e.g., all the regions are pending in one worker and other workers are just waiting. Meanwhile, the utilization of TiKV CPU is low, and the resolve progress can take a long time.
client-go/txnkv/rangetask/range_task.go
Line 54 in 279dcd5
This PR set the task size to 1 for p-dml, so that the resolve progress can run at the concurrency given by user.
The resolve lock speed:
The progress logs work well with this change: