Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: testify the autoscaling/compatibility/dashboard/pdbackup tests #5120

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jun 7, 2022

Signed-off-by: JmPotato [email protected]

What problem does this PR solve?

Issue Number: ref #4813.

What is changed and how does it work?

Testify the autoscaling/compatibility/dashboard/pdbackup tests.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/testing CI testing. label Jun 7, 2022
@JmPotato JmPotato requested a review from rleungx June 7, 2022 09:20
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #5120 (578027c) into master (5ace930) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5120      +/-   ##
==========================================
+ Coverage   75.49%   75.56%   +0.06%     
==========================================
  Files         309      309              
  Lines       30515    30515              
==========================================
+ Hits        23038    23058      +20     
+ Misses       5475     5452      -23     
- Partials     2002     2005       +3     
Flag Coverage Δ
unittests 75.56% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
pkg/tempurl/tempurl.go 60.00% <0.00%> (-10.00%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/tso/tso.go 69.49% <0.00%> (-4.52%) ⬇️
server/member/member.go 62.10% <0.00%> (-3.69%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
pkg/etcdutil/etcdutil.go 86.20% <0.00%> (-2.30%) ⬇️
server/election/leadership.go 75.25% <0.00%> (-2.07%) ⬇️
server/election/lease.go 84.05% <0.00%> (-1.45%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ace930...578027c. Read the comment docs.

@JmPotato JmPotato mentioned this pull request Jun 8, 2022
85 tasks
@JmPotato JmPotato requested a review from rleungx June 8, 2022 07:04
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 8, 2022
Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 9, 2022
@JmPotato
Copy link
Member Author

JmPotato commented Jun 9, 2022

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 93c9a8e

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 9, 2022
JmPotato added 2 commits June 9, 2022 14:57
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 9, 2022
@JmPotato
Copy link
Member Author

JmPotato commented Jun 9, 2022

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 578027c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2022
@ti-chi-bot ti-chi-bot merged commit f82e15e into tikv:master Jun 9, 2022
@JmPotato JmPotato deleted the testify_tests branch June 9, 2022 07:10
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
…tikv#5120)

ref tikv#4813

Testify the autoscaling/compatibility/dashboard/pdbackup tests.

Signed-off-by: JmPotato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/testing CI testing. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants