Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/testutil: add a WithTestify func for CheckTransferLeader #5213

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

LLThomas
Copy link
Contributor

Signed-off-by: LLThomas [email protected]

What problem does this PR solve?

Issue Number: Ref #4813

What is changed and how does it work?

Add a WithTestify func for CheckTransferLeader and CheckTransferLeaderWithTestify will be used in server/cluster/coordinator_test.go.

View comment.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 22, 2022
@ti-chi-bot ti-chi-bot requested review from disksing and rleungx June 22, 2022 10:35
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2022
@nolouch
Copy link
Contributor

nolouch commented Jun 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2097606

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@nolouch
Copy link
Contributor

nolouch commented Jun 22, 2022

ci failed.

@LLThomas
Copy link
Contributor Author

ci failed.

I will fix it.

Signed-off-by: LLThomas <[email protected]>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #5213 (e49ef93) into master (170b498) will increase coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5213      +/-   ##
==========================================
+ Coverage   75.64%   75.76%   +0.11%     
==========================================
  Files         310      310              
  Lines       30673    30678       +5     
==========================================
+ Hits        23204    23244      +40     
+ Misses       5462     5435      -27     
+ Partials     2007     1999       -8     
Flag Coverage Δ
unittests 75.76% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/testutil/operator_check.go 79.64% <0.00%> (-3.69%) ⬇️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
server/member/member.go 63.68% <0.00%> (-2.11%) ⬇️
server/election/leadership.go 75.25% <0.00%> (-2.07%) ⬇️
client/base_client.go 79.38% <0.00%> (-2.07%) ⬇️
server/tso/allocator_manager.go 63.72% <0.00%> (-1.00%) ⬇️
client/client.go 68.51% <0.00%> (-0.11%) ⬇️
server/region_syncer/client.go 86.56% <0.00%> (ø)
server/grpc_service.go 51.97% <0.00%> (+0.35%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 170b498...e49ef93. Read the comment docs.

@lhy1024
Copy link
Contributor

lhy1024 commented Jun 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e49ef93

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@ti-chi-bot ti-chi-bot merged commit 18fbc4a into tikv:master Jun 22, 2022
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
ref tikv#4813

Add a WithTestify func for CheckTransferLeader and CheckTransferLeaderWithTestify will be used in server/cluster/coordinator_test.go.

Signed-off-by: LLThomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants