Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts, tests: update the check-test.sh to detect more inefficient assert functions #5219

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

JmPotato
Copy link
Member

Signed-off-by: JmPotato [email protected]

What problem does this PR solve?

Issue Number: ref #4813.

What is changed and how does it work?

Update the check-test.sh to detect more inefficient assert functions.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

image

Release note

None.

@JmPotato JmPotato added component/testing CI testing. require-LGT1 Indicates that the PR requires an LGTM. labels Jun 23, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 23, 2022
@ti-chi-bot ti-chi-bot requested a review from rleungx June 23, 2022 02:37
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 23, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #5219 (6afc7f8) into master (3b3ff69) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5219      +/-   ##
==========================================
- Coverage   75.66%   75.49%   -0.18%     
==========================================
  Files         310      310              
  Lines       30674    30674              
==========================================
- Hits        23211    23157      -54     
- Misses       5478     5509      +31     
- Partials     1985     2008      +23     
Flag Coverage Δ
unittests 75.49% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/tso/local_allocator.go 62.16% <0.00%> (-13.52%) ⬇️
server/storage/endpoint/rule.go 83.33% <0.00%> (-11.12%) ⬇️
...erver/config/service_middleware_persist_options.go 91.66% <0.00%> (-8.34%) ⬇️
server/tso/allocator_manager.go 59.90% <0.00%> (-4.83%) ⬇️
pkg/dashboard/adapter/manager.go 79.31% <0.00%> (-4.60%) ⬇️
server/schedule/hbstream/heartbeat_streams.go 72.72% <0.00%> (-2.03%) ⬇️
client/base_client.go 79.89% <0.00%> (-1.55%) ⬇️
server/region_syncer/client.go 86.56% <0.00%> (-1.50%) ⬇️
server/schedule/operator_controller.go 84.56% <0.00%> (-1.21%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b3ff69...6afc7f8. Read the comment docs.

@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6afc7f8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2022
@ti-chi-bot ti-chi-bot merged commit 2aa6049 into tikv:master Jun 23, 2022
@JmPotato JmPotato deleted the refine_testify_script branch June 23, 2022 02:53
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
…ssert functions (tikv#5219)

ref tikv#4813

Update the check-test.sh to detect more inefficient assert functions.

Signed-off-by: JmPotato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/testing CI testing. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants