Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: clean up the leak options #5336

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 20, 2022

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Ref #4813.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 20, 2022
@ti-chi-bot ti-chi-bot requested review from disksing and nolouch July 20, 2022 05:38
@rleungx rleungx marked this pull request as ready for review July 20, 2022 05:48
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #5336 (90f9144) into master (97be557) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 90f9144 differs from pull request most recent head 6f76b9b. Consider uploading reports for the commit 6f76b9b to get more accurate results

@@            Coverage Diff             @@
##           master    #5336      +/-   ##
==========================================
- Coverage   75.78%   75.73%   -0.05%     
==========================================
  Files         312      312              
  Lines       31049    30966      -83     
==========================================
- Hits        23529    23453      -76     
+ Misses       5520     5505      -15     
- Partials     2000     2008       +8     
Flag Coverage Δ
unittests 75.73% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
server/statistics/buckets/hot_bucket_task.go 85.71% <0.00%> (-9.53%) ⬇️
server/id/id.go 76.19% <0.00%> (-8.43%) ⬇️
pkg/dashboard/adapter/redirector.go 84.44% <0.00%> (-6.86%) ⬇️
server/storage/storage.go 67.30% <0.00%> (-3.85%) ⬇️
pkg/etcdutil/etcdutil.go 84.88% <0.00%> (-3.49%) ⬇️
server/storage/endpoint/meta.go 61.36% <0.00%> (-2.28%) ⬇️
server/tso/tso.go 68.92% <0.00%> (-2.26%) ⬇️
server/tso/allocator_manager.go 64.55% <0.00%> (-1.78%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97be557...6f76b9b. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 25, 2022
@disksing disksing added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 25, 2022
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 90f9144

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 25, 2022
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7187a7a into tikv:master Jul 25, 2022
@rleungx rleungx deleted the cleanup-leak-option branch July 25, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants