build: force use latest protobuf-build #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BusyJay
approved these changes
Jun 20, 2023
|
@BusyJay Thanks for your review! However, there can be some more issues on protobuf-build (see tikv/protobuf-build#67) so perhaps we postpone to upgrade to that new version. |
This comment was marked as off-topic.
This comment was marked as off-topic.
I'm unsure the resolving rules here but it seems 0.7.0 raft-proto possibly resolve 0.14.0 protobuf-build when building TiKV: ``` error: failed to run custom build command for `raft-proto v0.7.0 (https://github.com/tikv/raft-rs?branch=master#f7376671)` Caused by: process didn't exit successfully: `/Users/tison/Brittani/tikv/target/debug/build/raft-proto-b62429cc873a021e/build-script-build` (exit status: 101) --- stderr thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /Users/tison/.cargo/registry/src/garden.eu.org-1ecc6299db9ec823/protobuf-build-0.14.0/src/protobuf_impl.rs:48:71 stack backtrace: 0: rust_begin_unwind at /rustc/96ddd32c4bfb1d78f0cd03eb068b1710a8cebeef/library/std/src/panicking.rs:575:5 1: core::panicking::panic_fmt at /rustc/96ddd32c4bfb1d78f0cd03eb068b1710a8cebeef/library/core/src/panicking.rs:65:14 2: core::panicking::panic at /rustc/96ddd32c4bfb1d78f0cd03eb068b1710a8cebeef/library/core/src/panicking.rs:114:5 3: core::option::Option<T>::unwrap 4: protobuf_build::protobuf_impl::check_protoc_version 5: protobuf_build::protobuf_impl::get_protoc 6: protobuf_build::protobuf_impl::<impl protobuf_build::Builder>::generate_files 7: protobuf_build::Builder::generate 8: build_script_build::main 9: core::ops::function::FnOnce::call_once note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. warning: build failed, waiting for other jobs to finish... ``` cc @BusyJay Signed-off-by: tison <[email protected]>
tisonkun
force-pushed
the
tisonkun-patch-1
branch
from
3dc2e89 to
692bcd1
Compare
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
|
Looks good now. Pending to merging... Since TiKV depend on this project with git ref, perhaps we don't have to do a release. |
Xuanwo
approved these changes
Jul 19, 2023
|
Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure the resolving rules here but it seems 0.7.0 raft-proto possibly resolve 0.14.0 protobuf-build when building TiKV:
cc @BusyJay