Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit tools #121

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Pre-commit tools #121

merged 5 commits into from
Dec 21, 2022

Conversation

benoit9126
Copy link
Contributor

@benoit9126 benoit9126 commented Dec 20, 2022

A lot of small modifications here:

  • I have added pre-commit with a set of basic tools.
  • I applied this to the entire repository, so a lot of files have been modified.
  • The configuration for this set of new tool is in a pyproject.toml file and in a .flake8 file (as flake8 does not support pyproject.toml)
  • I have added a GHA related to pre-commit
  • I forced the usage of f-strings
  • Shapely raised some warnings that I tried to remove

@coveralls
Copy link

coveralls commented Dec 20, 2022

Coverage Status

Coverage decreased (-0.3%) to 76.754% when pulling f0fa6ed on benoit9126:pre-commit into 12f93f1 on tilezen:master.

Copy link
Member

@rmarianski rmarianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just want to make sure that the removal of the setup.cfg doesn't have any side effects for existing users.

@@ -1,2 +0,0 @@
[bdist_wheel]
universal=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this have any consequences for existing usage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved this parameter in the pyproject.toml file. I wanted to limit the number of configuration files. I did it in advance as I hope that, in a future PR, the setup.py file will be removed from the repository (to be replaced with additional data pyproject.toml)

@rmarianski rmarianski merged commit 066d665 into tilezen:master Dec 21, 2022
@benoit9126 benoit9126 deleted the pre-commit branch December 21, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants