Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type -> geom_type #124

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Update type -> geom_type #124

merged 3 commits into from
Jan 3, 2023

Conversation

rmarianski
Copy link
Member

The shapely type property is deprecated. This updates our usage to use the geom_type property instead.

shapely/shapely#975

@rmarianski
Update type -> geom_type
dfa1a41 
The shapely `type` property is deprecated. This updates our usage to use
the `geom_type` property instead.

shapely/shapely#975
@coveralls
Copy link

coveralls commented Dec 22, 2022 •
edited
Loading

Coverage Status

Coverage: 77.341% (-0.7%) from 78.038% when pulling c24f645 on geom_type into 5249a23 on master.

@benoit9126
Copy link
Contributor

Great!

I think that the SimpleShape class can also be fully deleted and the shapely shape function used instead. See here.

@rmarianski
Copy link
Member Author

I think that the SimpleShape class can also be fully deleted and the shapely shape function used instead. See here.

good call 🙇 Removed it in 46a118d

@benoit9126 benoit9126 mentioned this pull request Jan 2, 2023
Merged
@rmarianski rmarianski merged commit 5d0dd19 into master Jan 3, 2023
@rmarianski rmarianski deleted the geom_type branch January 3, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmarianski @coveralls @benoit9126