Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to extend Timescaledb::ActsAsHypertable in a lazy load hook #75

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

ryoung
Copy link
Contributor

@ryoung ryoung commented Sep 24, 2024

Directly extending forcibly loads ActiveRecord::Base in the initializer. Instead we should be using hooks to defer loading until it’s actually needed.

For reference - https://api.rubyonrails.org/classes/ActiveSupport/LazyLoadHooks.html

@jonatas
Copy link
Collaborator

jonatas commented Sep 26, 2024

Thanks for bringing this @ryoung! I never used it, I'll consider also migrating all docs and hooks to use it too. I have some work in progress to let the user introduce the extend hooks as they want.

Thanks for the contribution 🚀

@jonatas jonatas merged commit 17970b0 into timescale:master Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants