Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cjg/waveform mode #11

Merged
merged 3 commits into from
Jul 21, 2017
Merged

Cjg/waveform mode #11

merged 3 commits into from
Jul 21, 2017

Conversation

Cody-G
Copy link
Collaborator

@Cody-G Cody-G commented Jul 11, 2017

This supports recent (non-breaking) changes to the Imagine format.

Cody-G added 2 commits July 11, 2017 10:04
…plied signals. Support this convention for header fields that contain quantities, parse them as NaNs.
@timholy
Copy link
Owner

timholy commented Jul 11, 2017

Can you add an example header file that has some of these fields? Or perhaps just edit https://github.com/timholy/ImagineFormat.jl/blob/master/test/test.imagine directly?

@Cody-G
Copy link
Collaborator Author

Cody-G commented Jul 20, 2017

Good idea! I just updated test.imagine and also changed a field to NA for testing. Note the failure is on nightly and unrelated.

@timholy timholy merged commit 2657497 into timholy:master Jul 21, 2017
@timholy
Copy link
Owner

timholy commented Jul 21, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants