Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete minor unreachable code caused by t.Fatal #780

Closed
wants to merge 1 commit into from
Closed

delete minor unreachable code caused by t.Fatal #780

wants to merge 1 commit into from

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly [email protected]

https://pkg.go.dev/testing#T.Fatal

Fatal is equivalent to Log followed by FailNow.

so break will not run.

@aforge
Copy link
Contributor

aforge commented Aug 8, 2022

Thanks. Can you merge it into next (not master) please?

@Abirdcfly
Copy link
Contributor Author

Thanks. Can you merge it into next (not master) please?

sure. close this for support #781

@Abirdcfly Abirdcfly closed this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abirdcfly @aforge