fix: update types for defaultValue #2237
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Wrong typings for
defaultValue
ref: #2236
Solution
Force
defaultValue
toany
type.Commander actually don't check types at code (except
undefined
) when use value.We see that the tests pass successfully with types other then defined now.
commander.js/tests/argument.custom-processing.test.js
Lines 52 to 62 in 4e87829