Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style-guide: add Arabic translation #15583

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

style-guide: add Arabic translation #15583

wants to merge 3 commits into from
+252 −0

Conversation

MachiavelliII
Copy link
Collaborator

It follows the main guidelines and some specific rules for Arabic.
Could you verify this?

@github-actions github-actions bot added the documentation Issues/PRs modifying the documentation. label Jan 22, 2025
@MachiavelliII
style-guide: add Arabic translation
e166148 
Replace الإرشادات with التوثيقات
@sebastiaanspeck
Copy link
Member

It follows the main guidelines and some specific rules for Arabic.

Could you verify this?

I can't since I do not speak Arabic. I can not approve this right now.

@sebastiaanspeck sebastiaanspeck removed their request for review February 7, 2025 01:55
kbdharun
kbdharun approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution. I am not a native speaker so I validated the additions using Google translate.

Btw, if it's possible can you add the newer additions to the style guide here too (see the file's commit history). If not we can merge this PR in it's current state since it's been open for a while.

@MachiavelliII
Copy link
Collaborator Author

LGTM, thanks for your contribution. I am not a native speaker so I validated the additions using Google translate.

Btw, if it's possible can you add the newer additions to the style guide here too (see the file's commit history). If not we can merge this PR in it's current state since it's been open for a while.

Do you mean these changes #15749 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@kant kant Awaiting requested review from kant

@sbrl sbrl Awaiting requested review from sbrl

@spageektti spageektti Awaiting requested review from spageektti

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MachiavelliII @sebastiaanspeck @kbdharun