Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textsplitter: add an optional lenFunc to MarkdownTextSplitter #1096

Merged

Conversation

pedramr
Copy link
Contributor

@pedramr pedramr commented Jan 6, 2025

Based on the custom lenFuc already supported in RecursiveCharacter splitter in 8734b6.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

Based on the custom lenFuc supported in RecursiveCharacter splitter in
8734b60
@FluffyKebab FluffyKebab merged commit 71ded3c into tmc:main Jan 7, 2025
3 checks passed
@pedramr
Copy link
Contributor Author

pedramr commented Jan 7, 2025

Thanks @FluffyKebab! Out of curiosity, what's the release cadence of the project? I see the latest release (v0.1.12) was cut on June 20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants