Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgvector: Fix DropTable Function #441

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

mehulmshah
Copy link
Contributor

Overview

See issue #440. DropTables() returns an error:

ERROR: cannot drop table "Collections" because other objects depend on it (SQLSTATE 2BP01)

Switched the order to drop the s.embeddingTableName Table first, and then the s.collectionTableName Table.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this really should be covered by a test, but LGTM. Thanks for your contribution.

If you have the time could you add a test that exercises this?

@tmc tmc merged commit dcae4f6 into tmc:main Dec 20, 2023
3 checks passed
@mehulmshah
Copy link
Contributor Author

Hmm this really should be covered by a test, but LGTM. Thanks for your contribution.

If you have the time could you add a test that exercises this?

Agreed. Sure thing, I'll find some time this month to add a test case for this. Also, thoughts on adding more functionality around ability to delete embeddings / collections by ID or other field(besides the preDelete function)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants