llms: Add mistral hosted inference llm implementation #717
Conversation
aannirajpatel
force-pushed
the
add-mistral
branch
from
2f89d4b to
c918d1d
Compare
aannirajpatel
force-pushed
the
add-mistral
branch
from
c918d1d to
c24a3d9
Compare
tmc
changed the title
aannirajpatel
force-pushed
the
add-mistral
branch
3 times, most recently
from
d9257d9 to
61c4fbb
Compare
|
|
||
| type Option func(*clientOptions) | ||
|
|
||
| func WithAPIKey(apiKey string) Option { |
There was a problem hiding this comment.
please include comments on exported symbols
There was a problem hiding this comment.
typically in go these start with the string of the symbol, so in this case it would be appropriate to start with "// WithAPIKey passes the .."
There was a problem hiding this comment.
I see it's already merged (thanks!). I'll change these up as a follow-up PR on the coming weekend.
aannirajpatel
force-pushed
the
add-mistral
branch
from
61c4fbb to
9a89f48
Compare
Ahh, missed it 😅 Just learned about that on social media. Cool hackathon! |
aannirajpatel
force-pushed
the
add-mistral
branch
from
9a89f48 to
1a9b6d5
Compare
examples/mistral-completion-example/mistral_completion_example.go
Outdated
Show resolved
Hide resolved
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| _ = completionWithStreaming |
There was a problem hiding this comment.
folks that know go well may understand why this line is here but a comment would be useful
* llms: added streaming to mistral * examples: added mistral completion example
aannirajpatel
force-pushed
the
add-mistral
branch
from
1a9b6d5 to
56d4dce
Compare
|
Really impressed with the docs additon! Thanks so much, I'd like to normalize that for new contributors and would love any input you have to make that more accessible or straightforward. I commented with a note about how we tend to start comments on exported functions/types in this codebase, I think that's the only snag that remains here! |
|
🙏 merged. |
Adds an LLM implementation to leverage the Mistral Platform. Wraps mistral-go.
Requesting feedback on Function calling-related implementation.
Checklist
✅ I have read the Contributing documentation.
✅ I have read the Code of conduct documentation.
✅ I checked that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
✅ My PR provides a description that addresses what it is solving, with a focus on integrating Mistral LLMs into LangChain.
✅ My PR describes the source of new concepts introduced (no new concepts introduced).
✅ My PR references existing implementations as appropriate, primarily the mistral-go client library documentation.
🟡 PR should contain test coverage for new functions (to be added - question to maintainers: can these be added retrospectively?).
✅ Verified that my PR passes all golangci-lint checks.
resolves #486