simple fixes

tmfg · Jan 15, 2025 · 3ac6cf0 · 3ac6cf0
1 parent 14bce7c
commit 3ac6cf0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/...taUpdater/src/main/java/fi/livi/rata/avoindata/updater/service/gtfs/GTFSStopsService.java b/...taUpdater/src/main/java/fi/livi/rata/avoindata/updater/service/gtfs/GTFSStopsService.java
@@ -75,8 +75,7 @@ public Map<String, Stop> createStops(final Map<Long, Map<List<LocalDate>, Schedu
         });
 
         final Map<String, StationEmbeddable> uniqueStationEmbeddables = new HashMap<>();
-        for (final Long trainNumber : scheduleIntervalsByTrain.keySet()) {
-            final Map<List<LocalDate>, Schedule> trainsSchedules = scheduleIntervalsByTrain.get(trainNumber);
+        for (final Map<List<LocalDate>, Schedule> trainsSchedules : scheduleIntervalsByTrain.values()) {
             for (final List<LocalDate> localDates : trainsSchedules.keySet()) {
                 final Schedule schedule = trainsSchedules.get(localDates);
                 for (final ScheduleRow scheduleRow : schedule.scheduleRows) {

diff --git a/...ataUpdater/src/main/java/fi/livi/rata/avoindata/updater/service/gtfs/GTFSTripService.java b/...ataUpdater/src/main/java/fi/livi/rata/avoindata/updater/service/gtfs/GTFSTripService.java
@@ -371,7 +371,7 @@ private List<StopTime> createStopTimes(final Schedule schedule, final String tri
             stopTimes.add(stopTime);
         }
 
-        stopTimes.get(0).dropoffType = 1;
+        stopTimes.getFirst().dropoffType = 1;
         Iterables.getLast(stopTimes).pickupType = 1;
 
         return stopTimes;

diff --git a/...ater/src/main/java/fi/livi/rata/avoindata/updater/service/gtfs/entities/PlatformData.java b/...ater/src/main/java/fi/livi/rata/avoindata/updater/service/gtfs/entities/PlatformData.java
@@ -32,6 +32,8 @@ public Optional<InfraApiPlatform> getStationPlatform(final String stationShortCo
     }
 
     public boolean isValidTrack(final String stationShortCode, final String track) {
-        return validTracksByStation.getOrDefault(stationShortCode, Collections.emptySet()).contains(track);
+        final var stationTracks = validTracksByStation.get(stationShortCode);
+
+        return stationTracks != null && stationTracks.contains(track);
     }
 }