Fail job when required inputs are whitespace strings #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
7837f1d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a90a8d56.cloudflare-pages-deploy-action.pages.dev |
| Branch Preview URL: | https://debug-project-error.cloudflare-pages-deploy-action.pages.dev |
tomjschuster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an input parameter contains only whitespace,
getInputfrom@actions/corewill succeed as an empty string whenrequired: true. When fetching the Cloudflare Pages project, the "Get Project" url (/accounts/:accountId/pages/projects/:projectId) ends up being shortened to"List Projects" (
/accounts/:accountId/pages/projects) which ends up in a runtime error as a list of projects is returned instead of a single project.This PR makes the job fail earlier when any required string input is parsed as an empty string, resulting a descriptive input error as opposed to a runtime error later in the flow.