Skip to content

Commit

Permalink
chore: add info about aad-pod-identity deprecation (kedacore#5036)
Browse files Browse the repository at this point in the history
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: anton.lysina <[email protected]>
  • Loading branch information
2 people authored and toniiiik committed Jan 15, 2024
1 parent 010bd09 commit 116be52
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ You can find all deprecations in [this overview](https://github.com/kedacore/ked

New deprecation(s):

- TODO ([#XXX](https://github.com/kedacore/keda/issues/XXX))
- Remove support for Azure AD Pod Identity-based authentication ([#5035](https://github.com/kedacore/keda/issues/5035))

### Breaking Changes

Expand Down
4 changes: 4 additions & 0 deletions pkg/scaling/resolver/scale_resolvers.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,10 @@ func ResolveAuthRefAndPodIdentity(ctx context.Context, client client.Client, log
case kedav1alpha1.PodIdentityProviderAwsKiam:
authParams["awsRoleArn"] = podTemplateSpec.ObjectMeta.Annotations[kedav1alpha1.PodIdentityAnnotationKiam]
case kedav1alpha1.PodIdentityProviderAzure, kedav1alpha1.PodIdentityProviderAzureWorkload:
if podIdentity.Provider == kedav1alpha1.PodIdentityProviderAzure {
// FIXME: Delete this for v2.15
logger.Info("WARNING: Azure AD Pod Identity has been archived (https://github.com/Azure/aad-pod-identity#-announcement) and will be removed from KEDA on v2.15")
}
if podIdentity.IdentityID != nil && *podIdentity.IdentityID == "" {
return nil, kedav1alpha1.AuthPodIdentity{Provider: kedav1alpha1.PodIdentityProviderNone}, fmt.Errorf("IdentityID of PodIdentity should not be empty")
}
Expand Down

0 comments on commit 116be52

Please sign in to comment.