Generic TopK implementation #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soumith @wickedfoo This is ready. |
killeent
changed the title
wickedfoo
approved these changes
Apr 24, 2017
lib/THC/THCTensorTopK.cuh
Outdated
| typedef unsigned int RadixType; | ||
|
|
||
| static inline __device__ RadixType convert(short v) { | ||
| return 32768u + v; |
There was a problem hiding this comment.
add a static assert that sizeof(short) == 2 to ensure that this is a correct constant
lib/THC/THCTensorTopK.cuh
Outdated
| typedef unsigned int RadixType; | ||
|
|
||
| static inline __device__ RadixType convert(int v) { | ||
| return 2147483648u + v; |
There was a problem hiding this comment.
add a static assert that sizeof(int) == 4 to ensure that this is a correct constant
lib/THC/THCTensorTopK.cuh
Outdated
| typedef unsigned long long int RadixType; | ||
|
|
||
| static inline __device__ RadixType convert(long v) { | ||
| return 9223372036854775808ull + v; |
There was a problem hiding this comment.
add a static assert that sizeof(long) == 8 to ensure that this is a correct constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes TopK generic. The main changes required to do this were: