websocket: Periodic pinging for failure detection #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes tornadowebgh-1640 As Ben requested on tornadoweb#1640, I've changed it to work in seconds rather than milliseconds. I'm not sure how we'd test something like this. I don't think we have tests for it in Jupyter.
In order to implement proper application-level handling of disconnections a developer may want to hook up into the standard "ping" mechanism of the websocket protocol. This is important for systems where both the client and the server need to keep track of disconnections, but based on client-intiated pings only.
Add a basic test.
|
I think it needs. If the server does not do ping and on_pong(with timeout check), I would like to manually implement the ping on client to ensure that the connection. |
bdarnell
changed the title
|
@awong1900 Why do you want to do it manually? (notice that you can pass |
|
I checked your commit code. If have 'ping_interval' on client, I think no need to control ping manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally ping the other end of a websocket connection periodically, and close the connection if no response is received (to supplement kernel-level failure detection for the TCP connections, and to keep some proxies from dropping the connection).
Fixes #1640
Closes #1642
Closes #1938
@takluyver and @astawiarski, your changes are included here. @awong1900, you asked for a client-side
ping()method in #1640. Do you really need manual control of pings (and responses) or is thisping_intervalandping_timeoutenough for you?