Merge #732: Docs: benchmarking

45c77c3 fix: linter error, unused code (Jose Celano)
d32a748 docs: [#87] benchmarking (Jose Celano)
fd0ad1b test: [#87] remove lua script for HTTP tracker benchmarking (Jose Celano)

Pull request description:

  - How to run E2E load tests with aquatic load test commands.
  - How to run storage implementations benchmarking report.

ACKs for top commit:
  josecelano:
    ACK 45c77c3

Tree-SHA512: 7523262981adf59dadc638366e7bc2b5bc5999517dd97bf68a1341cacdfdc4c9418f9852bdf904e0e401b2a4758795ebdf8e0b33d148f15458382b25c1ac6186

README.md

@@ -126,6 +126,10 @@ The following services are provided by the default configuration:
 - [Tracker (HTTP/TLS)][HTTP]
 - [Tracker (UDP)][UDP]
 
+## Benchmarking
+
+- [Benchmarking](./docs/benchmarking.md)
+
 ## Contributing
 
 We are happy to support and welcome new people to our project. Please consider our [contributor guide][guide.md].</br>

cSpell.json

@@ -50,6 +50,7 @@
         "hexlify",
         "hlocalhost",
         "Hydranode",
+        "hyperthread",
         "Icelake",
         "imdl",
         "impls",

docs/benchmarking.md

@@ -0,0 +1,252 @@
+# Benchmarking
+
+We have two types of benchmarking:
+
+- E2E benchmarking running the service (HTTP or UDP tracker).
+- Internal torrents repository benchmarking.
+
+## E2E benchmarking
+
+We are using the scripts provided by [aquatic](https://github.com/greatest-ape/aquatic).
+
+Installing both commands:
+
+```console
+cargo install aquatic_udp_load_test
+cargo install aquatic_http_load_test
+```
+
+### Run UDP load test
+
+Run the tracker with UDP service enabled on port 3000 and set log level to `error`.
+
+```toml
+log_level = "error"
+
+[[udp_trackers]]
+bind_address = "0.0.0.0:3000"
+enabled = true
+```
+
+Run the load test with:
+
+```console
+aquatic_udp_load_test
+```
+
+Output:
+
+```output
+Starting client with config: Config {
+    server_address: 127.0.0.1:3000,
+    log_level: Error,
+    workers: 1,
+    duration: 0,
+    network: NetworkConfig {
+        multiple_client_ipv4s: true,
+        first_port: 45000,
+        poll_timeout: 276,
+        poll_event_capacity: 2877,
+        recv_buffer: 6000000,
+    },
+    requests: RequestConfig {
+        number_of_torrents: 10000,
+        scrape_max_torrents: 50,
+        weight_connect: 0,
+        weight_announce: 100,
+        weight_scrape: 1,
+        torrent_gamma_shape: 0.2,
+        torrent_gamma_scale: 100.0,
+        peer_seeder_probability: 0.25,
+        additional_request_probability: 0.5,
+    },
+}
+
+Requests out: 32632.43/second
+Responses in: 24239.33/second
+  - Connect responses:  7896.91
+  - Announce responses: 16327.01
+  - Scrape responses:   15.40
+  - Error responses:    0.00
+Peers per announce response: 33.10
+```
+
+### Run HTTP load test
+
+Run the tracker with UDP service enabled on port 3000 and set log level to `error`.
+
+```toml
+[[udp_trackers]]
+bind_address = "0.0.0.0:3000"
+enabled = true
+```
+
+Run the load test with:
+
+```console
+aquatic_http_load_test
+```
+
+Output:
+
+```output
+Starting client with config: Config {
+    server_address: 127.0.0.1:3000,
+    log_level: Error,
+    num_workers: 1,
+    num_connections: 128,
+    connection_creation_interval_ms: 10,
+    url_suffix: "",
+    duration: 0,
+    keep_alive: true,
+    torrents: TorrentConfig {
+        number_of_torrents: 10000,
+        peer_seeder_probability: 0.25,
+        weight_announce: 5,
+        weight_scrape: 0,
+        torrent_gamma_shape: 0.2,
+        torrent_gamma_scale: 100.0,
+    },
+    cpu_pinning: CpuPinningConfigDesc {
+        active: false,
+        direction: Descending,
+        hyperthread: System,
+        core_offset: 0,
+    },
+}
+```
+
+### Comparing UDP tracker with other Rust implementations
+
+#### Torrust UDP Tracker
+
+Running the tracker:
+
+```console
+[email protected]:torrust/torrust-tracker.git
+cd torrust-tracker
+cargo build --release
+TORRUST_TRACKER_PATH_CONFIG="./share/default/config/tracker.udp.benchmarking.toml" ./target/release/torrust-tracker
+```
+
+Running the test: `aquatic_udp_load_test`.
+
+```output
+Requests out: 13075.56/second
+Responses in: 12058.38/second
+  - Connect responses:  1017.18
+  - Announce responses: 11035.00
+  - Scrape responses:   6.20
+  - Error responses:    0.00
+Peers per announce response: 41.13
+```
+
+#### Aquatic UDP Tracker
+
+Running the tracker:
+
+```console
+git clone [email protected]:greatest-ape/aquatic.git
+cd aquatic
+cargo build --release -p aquatic_udp
+./target/release/aquatic_udp -c "aquatic-udp-config.toml"
+./target/release/aquatic_udp -c "aquatic-udp-config.toml"
+```
+
+Running the test: `aquatic_udp_load_test`.
+
+```output
+Requests out: 383873.14/second
+Responses in: 383440.35/second
+  - Connect responses:  429.19
+  - Announce responses: 379249.22
+  - Scrape responses:   3761.93
+  - Error responses:    0.00
+Peers per announce response: 15.33
+```
+
+#### Torrust-Actix UDP Tracker
+
+Run the tracker with UDP service enabled on port 3000 and set log level to `error`.
+
+```toml
+[[udp_trackers]]
+bind_address = "0.0.0.0:3000"
+enabled = true
+```
+
+```console
+git clone https://github.com/Power2All/torrust-actix.git
+cd torrust-actix
+cargo build --release
+./target/release/torrust-actix --create-config
+./target/release/torrust-actix
+```
+
+Running the test: `aquatic_udp_load_test`.
+
+```output
+Requests out: 3072.94/second
+Responses in: 2395.15/second
+  - Connect responses:  556.79
+  - Announce responses: 1821.16
+  - Scrape responses:   17.20
+  - Error responses:    0.00
+Peers per announce response: 133.88
+```
+
+### Results
+
+Announce request per second:
+
+| Tracker       |  Announce |
+|---------------|-----------|
+| Aquatic       |   379,249 |
+| Torrust       |    11,035 |
+| Torrust-Actix |     1,821 |
+
+## Repository benchmarking
+
+You can run it with:
+
+```console
+cargo run --release -p torrust-torrent-repository-benchmarks -- --threads 4 --sleep 0 --compare true
+```
+
+It tests the different implementation for the internal torrent storage.
+
+```output
+tokio::sync::RwLock<std::collections::BTreeMap<InfoHash, Entry>>
+add_one_torrent: Avg/AdjAvg: (60ns, 59ns)
+update_one_torrent_in_parallel: Avg/AdjAvg: (10.909457ms, 0ns)
+add_multiple_torrents_in_parallel: Avg/AdjAvg: (13.88879ms, 0ns)
+update_multiple_torrents_in_parallel: Avg/AdjAvg: (7.772484ms, 7.782535ms)
+
+std::sync::RwLock<std::collections::BTreeMap<InfoHash, Entry>>
+add_one_torrent: Avg/AdjAvg: (43ns, 39ns)
+update_one_torrent_in_parallel: Avg/AdjAvg: (4.020937ms, 4.020937ms)
+add_multiple_torrents_in_parallel: Avg/AdjAvg: (5.896177ms, 5.768448ms)
+update_multiple_torrents_in_parallel: Avg/AdjAvg: (3.883823ms, 3.883823ms)
+
+std::sync::RwLock<std::collections::BTreeMap<InfoHash, Arc<std::sync::Mutex<Entry>>>>
+add_one_torrent: Avg/AdjAvg: (51ns, 49ns)
+update_one_torrent_in_parallel: Avg/AdjAvg: (3.252314ms, 3.149109ms)
+add_multiple_torrents_in_parallel: Avg/AdjAvg: (8.411094ms, 8.411094ms)
+update_multiple_torrents_in_parallel: Avg/AdjAvg: (4.106086ms, 4.106086ms)
+
+tokio::sync::RwLock<std::collections::BTreeMap<InfoHash, Arc<std::sync::Mutex<Entry>>>>
+add_one_torrent: Avg/AdjAvg: (91ns, 90ns)
+update_one_torrent_in_parallel: Avg/AdjAvg: (3.542378ms, 3.435695ms)
+add_multiple_torrents_in_parallel: Avg/AdjAvg: (15.651172ms, 15.651172ms)
+update_multiple_torrents_in_parallel: Avg/AdjAvg: (4.368189ms, 4.257572ms)
+
+tokio::sync::RwLock<std::collections::BTreeMap<InfoHash, Arc<tokio::sync::Mutex<Entry>>>>
+add_one_torrent: Avg/AdjAvg: (111ns, 109ns)
+update_one_torrent_in_parallel: Avg/AdjAvg: (6.590677ms, 6.808535ms)
+add_multiple_torrents_in_parallel: Avg/AdjAvg: (16.572217ms, 16.30488ms)
+update_multiple_torrents_in_parallel: Avg/AdjAvg: (4.073221ms, 4.000122ms)
+```
+
+## Other considerations
+
+We are testing new repository implementations that allow concurrent writes. See <https://github.com/torrust/torrust-tracker/issues/565>.

share/default/config/tracker.udp.benchmarking.toml

@@ -0,0 +1,37 @@
+announce_interval = 120
+db_driver = "Sqlite3"
+db_path = "./storage/tracker/lib/database/sqlite3.db"
+external_ip = "0.0.0.0"
+inactive_peer_cleanup_interval = 600
+log_level = "error"
+max_peer_timeout = 900
+min_announce_interval = 120
+mode = "public"
+on_reverse_proxy = false
+persistent_torrent_completed_stat = false
+remove_peerless_torrents = true
+tracker_usage_statistics = true
+
+[[udp_trackers]]
+bind_address = "0.0.0.0:3000"
+enabled = true
+
+[[http_trackers]]
+bind_address = "0.0.0.0:7070"
+enabled = false
+ssl_cert_path = ""
+ssl_enabled = false
+ssl_key_path = ""
+
+[http_api]
+bind_address = "127.0.0.1:1212"
+enabled = false
+ssl_cert_path = ""
+ssl_enabled = false
+ssl_key_path = ""
+
+[http_api.access_tokens]
+admin = "MyAccessToken"
+
+[health_check_api]
+bind_address = "127.0.0.1:1313"

src/console/clients/udp/responses.rs

@@ -68,13 +68,6 @@ impl From<ScrapeResponse> for ScrapeResponseDto {
     }
 }
 
-#[derive(Serialize)]
-struct Peer {
-    seeders: i32,
-    completed: i32,
-    leechers: i32,
-}
-
 #[derive(Serialize)]
 struct TorrentStats {
     seeders: i32,