Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #171
The
ExpiringKey::valid_until
(duration) does not need to be optional anymore since we introduced theKeyId
struct.Besides, after renaming the
Key
struct toExpiringKey
, there is no longer a conflict with theKeyId
, so we can use the nameKey
for theKeyId
again.Before:
After:
After this refactoring, you can read the code like this:
"An
ExpiringKey
is aKey
valid until a date expressed in a duration from the Unix epoch (timestamp)".