Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding set custom value feature to crashlytics log writer #308

Closed

Conversation

kprakash2
Copy link

Added setCustomValue() function to CrashlyticsLogWriter.

This will allow the clients to use kermit for their logs and add custom properties for crash reporting to crashlytics.

Added `setCustomValue()` function to `CrashlyticsLogWriter`.
@kprakash2 kprakash2 changed the title add set custom value feature to crashlytics adding set custom value feature to crashlytics log writer Nov 29, 2022
@kpgalligan
Copy link
Collaborator

Thanks for the submission. This is available with CrashKiOS. Do you need to add it to Kermit? Kermit is calling into CrashKiOS so adding it to the LogWriter seems unnecessary.

CrashlyticsKotlin.setCustomValue("someKey", "someValue")

https://github.com/touchlab/CrashKiOS#crashlytics-usage

@kprakash2
Copy link
Author

Thanks for the submission. This is available with CrashKiOS. Do you need to add it to Kermit? Kermit is calling into CrashKiOS so adding it to the LogWriter seems unnecessary.

CrashlyticsKotlin.setCustomValue("someKey", "someValue")

https://github.com/touchlab/CrashKiOS#crashlytics-usage

@kpgalligan That's what we are doing for now but it seems like kermit itself doesn't expose CrashKiOS so we had to bring that dependency separately but we still end up creating two different instances one: CrashlyticsLogger for kermit and one using CrashKiOS's enableCrashlytics() which is okay as I checked at the end, everything is delegated to the singleton instance of Firebase.

@samhill303
Copy link
Collaborator

Thanks for the input. We've decided not to make this change in Kermit as it is available in CrashKiOS

@samhill303 samhill303 closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants