Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ARB - remove metadata in the output" #354

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

deathbird
Copy link
Contributor

Problem and/or solution

We revert previous work so that in ARB format file metadata are included in the compiled files.

How to test

Reviewer checklist

Code:

  • Change is covered by unit-tests
  • Code is well documented, well styled and is following best practices
  • Performance issues have been taken under consideration
  • Errors and other edge-cases are handled properly

PR:

  • Problem and/or solution are well-explained
  • Commits have been squashed so that each one has a clear purpose
  • Commits have a proper commit message according to TEM

@deathbird deathbird force-pushed the revert-arb-remove-metadata-in-compiled-files branch from ad236c0 to 7877d1a Compare August 23, 2024 10:31
Copy link
Contributor

@foteinigk foteinigk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!🚀

@deathbird deathbird merged commit da3e7c2 into devel Aug 26, 2024
4 checks passed
@deathbird deathbird deleted the revert-arb-remove-metadata-in-compiled-files branch August 26, 2024 08:53
@txsentinel txsentinel mentioned this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants