Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Documentation #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arjunmalkani
Copy link

Improved documentations on a disclaimer for potential amazon TOS, a contribution guide, and table of contents.

Comment on lines +5 to +14
# Table of Contents

1. What This Tool Does
2. Disclaimer
3. Pre-Requisites
4. Installation
5. Running the Tool
6. CLI Arguments
7. Troubleshooting
8. Contribution Guide
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop the table of contents IMO. Github already provides a native TOC for markdown files.

@@ -96,3 +114,15 @@ There has also [been an indication](https://github.com/treetrum/amazon-kindle-bu
#### Error: Failed to parse CRSF token

This indicates that your login did not fully succeed. There are a multitude of reasons why this could happen however the simplest fix is often to login using the --manualAuth CLI flag instead of using the automated process.

### Contributions
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a H2. If it's a H3, it becomes part of the troubleshooting section.

@treetrum
Copy link
Owner

You will also need to fix the prettier issues referenced in the failed build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants