Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (#1072) React 19 Updates for Calendar, DatePicker and DateRangePicker #1151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ianlchapman
Copy link

Description

This pull request updates the dependencies used in the Calendar, DatePicker and DateRangePicker components so that they are compatible with React 19. Specifically this involved the following steps:

  1. Following the upgrade guide for React DayPicker (https://daypicker.dev/upgrading) and bumping dependencies
  2. Minor update to Jest configuration to support ESM modules

I have created the PR against the main branch as directed in the contribution guidelines. However it might be more appropriate that this goes out with other React 19 changes.

Related issue(s)

[Feature]: React 19 support

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Usage of the basic component is unchanged and will continue to function as it did previously. This is supported by no prop changes in Storybook or test suite.

As the current components passes it props down to the React DayPicker component there is the possibility that users might be passing props down which have changed between React DayPicker versions. These props are still passed but might be subject to deprecation in this release or future releases.

How has this been tested?

Functionality is verified against the current Storybook version for the applicable components. Both to ensure there are no regressions and that the external interface for the component is respected. Automated test suite is executed without any testing changes. Both actions executed on an Apple M1 MacBook Pro running Sequoia 15.1.1.

Screenshots (if appropriate):

The PR fulfils these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team) n/a no documentation change required
  • I have added tests to cover my changes. n/a existing test suite used to ensure compatibility
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 1:23pm
tremor-npm-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 1:23pm

Updated functionality on DatePicker and DateRangePicker components

Fixed issue with tests failing to run correctly

Fixed a few styling issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants