Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native Node.js USB library to @transport as a PoC #4770

Closed
tsusanka opened this issue Jan 19, 2022 · 1 comment · Fixed by #7820
Closed

Add native Node.js USB library to @transport as a PoC #4770

tsusanka opened this issue Jan 19, 2022 · 1 comment · Fixed by #7820
Assignees
Labels
code Code improvements

Comments

@tsusanka
Copy link
Contributor

tsusanka commented Jan 19, 2022

As discussed, let's try to add usb as a new transport layer to @transport.

  • There is a usage example in electron.
  • The v2.0.0 API should follow the WebUSB API specification which is definitely what we want. As we already have WebUSB implementation this could be quite easy.
  • For potential inspiration this is the Ledger's equivalent. They also have HID support for older devices but I would not worry about that just yet, let's try out this first.

This is a Proof of Concept kind of task, let's try it out, give it to QA, but definitely do not merge until we figure out the other questions raised :).

@tsusanka tsusanka added code Code improvements HIGH labels Jan 19, 2022
@hynek-jina hynek-jina assigned karliatto and unassigned mroz22 Mar 17, 2022
@mroz22 mroz22 mentioned this issue May 25, 2022
4 tasks
@hynek-jina hynek-jina moved this to 🎯 To do in Suite Desktop Jun 2, 2022
@hynek-jina hynek-jina removed the HIGH label Jun 8, 2022
@karliatto karliatto moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Desktop Jun 9, 2022
@hynek-jina hynek-jina moved this from 🏃‍♀️ In progress to 🎯 To do in Suite Desktop Jul 22, 2022
@mroz22 mroz22 mentioned this issue Oct 10, 2022
11 tasks
@hynek-jina hynek-jina moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Desktop Nov 3, 2022
@hynek-jina hynek-jina moved this from 🏃‍♀️ In progress to 🔎 Needs review in Suite Desktop Feb 2, 2023
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Suite Desktop Jun 26, 2023
@bosomt
Copy link
Contributor

bosomt commented Jul 3, 2023

QA OK

Info:

  • Suite version: desktop 23.7.0 (d81e7e2)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/23.7.0 Chrome/112.0.5615.204 Electron/24.5.1 Safari/537.36
  • OS: MacIntel
  • Screen: 1440x900
  • Device: model T 2.6.1 Universal (revision c3f6e8f19fd647c73b414322e287ba23cf8a0c7c)
  • Transport: NodeUsbTransport

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants