Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@trezor/transport nodeusb #7820

Merged
merged 1 commit into from
Jun 26, 2023
Merged

@trezor/transport nodeusb #7820

merged 1 commit into from
Jun 26, 2023

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Mar 12, 2023

based on #6509 which should be merged first.
resolve #4770

@mroz22 mroz22 force-pushed the transport-refactor-2 branch from 1fe819f to c5f08a7 Compare March 12, 2023 13:00
@mroz22 mroz22 mentioned this pull request Mar 12, 2023
11 tasks
@mroz22 mroz22 force-pushed the transport-refactor-2 branch 3 times, most recently from 360f581 to 9d64b5b Compare March 14, 2023 09:49
@mroz22 mroz22 force-pushed the transport-refactor-2 branch 8 times, most recently from 6c2fc04 to d1f2b11 Compare April 11, 2023 06:49
@mroz22 mroz22 force-pushed the transport-refactor-2 branch 8 times, most recently from 31db015 to de1454b Compare April 16, 2023 15:22
@mroz22 mroz22 force-pushed the transport-nodeusb branch from ca43db2 to 1a03b7e Compare April 17, 2023 14:30
@mroz22 mroz22 force-pushed the transport-refactor-2 branch from 5322801 to 5ac0f19 Compare April 24, 2023 07:27
@mroz22 mroz22 force-pushed the transport-nodeusb branch from 1a03b7e to f211e0b Compare April 24, 2023 20:50
@socket-security
Copy link

socket-security bot commented Apr 24, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@mroz22 mroz22 force-pushed the transport-refactor-2 branch 3 times, most recently from 6b01c61 to e18e79c Compare May 1, 2023 15:00
@mroz22 mroz22 force-pushed the transport-refactor-2 branch 2 times, most recently from 8e9fcad to c23b338 Compare May 3, 2023 22:41
@mroz22 mroz22 force-pushed the transport-refactor-2 branch 2 times, most recently from e379924 to b84b037 Compare June 10, 2023 16:35
Base automatically changed from transport-refactor-2 to develop June 12, 2023 05:39
@mroz22 mroz22 force-pushed the transport-nodeusb branch from 42e83e3 to a8ab361 Compare June 12, 2023 05:53
@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
usb 🆕 2.9.0 None +1 6.66 MB thegecko

Footnotes

  1. https://docs.socket.dev

@mroz22 mroz22 force-pushed the transport-nodeusb branch from a8ab361 to f710f5c Compare June 12, 2023 13:13
@mroz22 mroz22 marked this pull request as ready for review June 12, 2023 13:13
@mroz22 mroz22 force-pushed the transport-nodeusb branch 6 times, most recently from 659005a to 289c2e5 Compare June 16, 2023 08:37
@mroz22 mroz22 force-pushed the transport-nodeusb branch 4 times, most recently from f3a1a75 to eee086b Compare June 23, 2023 06:55
@mroz22
Copy link
Contributor Author

mroz22 commented Jun 23, 2023

@SocketSecurity ignore [email protected]

@marekrjpolak
Copy link
Contributor

Needed this change in shell.nix to yarn on NixOS. What do you think, @szymonlesisz?

Copy link
Contributor

@marekrjpolak marekrjpolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not saying it's working, but it's working 🥳

@mroz22
Copy link
Contributor Author

mroz22 commented Jun 26, 2023

/rebase

@github-actions
Copy link

@trezor-ci trezor-ci force-pushed the transport-nodeusb branch from f539e88 to 5f4d99b Compare June 26, 2023 13:20
@mroz22 mroz22 merged commit f0cee52 into develop Jun 26, 2023
@mroz22 mroz22 deleted the transport-nodeusb branch June 26, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add native Node.js USB library to @transport as a PoC
2 participants