Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite-native): add trading slice to mobile #17120

Merged
merged 1 commit into from
Feb 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions suite-common/trading/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ export * from './regional';
export * from './utils';
export * from './constants';
export * from './reducers/tradingReducer';
export type { TradingBuyState } from './reducers/buyReducer';
export * from './middlewares/tradingMiddleware';
export * from './actions/tradingActions';
export * from './actions/buyActions';
Expand Down
79 changes: 79 additions & 0 deletions suite-native/module-trading/src/__tests__/tradingSlice.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
import { extraDependenciesMock } from '@suite-common/test-utils';
import { Account } from '@suite-common/wallet-types';

import {
TradingState,
selectBuySelectedReceiveAccount,
setBuySelectedReceiveAccount,
tradingSlice,
} from '../tradingSlice';

const getBtcAccount = () =>
({
symbol: 'btc',
accountType: 'normal',
accountLabel: 'BTC Account',
addresses: {
used: [
{
address: '1BTC',
path: 'm/84/0/0',
transfers: 0,
balance: '0',
sent: '0',
received: '0',
},
],
change: [],
unused: [],
},
}) as unknown as Account;

describe('featureFlagsSlice', () => {
afterEach(() => {
jest.resetAllMocks();
});

describe('initial state', () => {
it('should have correct initial state', () => {
const tradingReducer = tradingSlice.prepareReducer(extraDependenciesMock);
const state = tradingReducer(undefined, {
type: 'undefined_action',
});

expect(state.buy.selectedReceiveAccount).toBeUndefined();
});
});

describe('buy', () => {
it('should set selectedReceiveAccount', () => {
const tradingReducer = tradingSlice.prepareReducer(extraDependenciesMock);
const receiveAccount = { account: getBtcAccount(), address: undefined };
const state = tradingReducer(
undefined,
setBuySelectedReceiveAccount({
selectedReceiveAccount: receiveAccount,
}),
);

expect(selectBuySelectedReceiveAccount({ wallet: { trading: state } })).toBe(
receiveAccount,
);
});

it('should set and clear selectedReceiveAccount', () => {
const tradingReducer = tradingSlice.prepareReducer(extraDependenciesMock);
const actions = [
setBuySelectedReceiveAccount({
selectedReceiveAccount: { account: getBtcAccount(), address: undefined },
}),
setBuySelectedReceiveAccount({
selectedReceiveAccount: undefined,
}),
];
const state = actions.reduce(tradingReducer, undefined) as TradingState;

expect(selectBuySelectedReceiveAccount({ wallet: { trading: state } })).toBeUndefined();
});
});
});
1 change: 1 addition & 0 deletions suite-native/module-trading/src/index.ts
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export * from './navigation/TradingStackNavigator';
export * from './tradingSlice';
11 changes: 11 additions & 0 deletions suite-native/module-trading/src/redux.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { AsyncThunkAction } from '@reduxjs/toolkit';

declare module 'redux' {
export interface Dispatch<A extends Action = AnyAction> {
<TThunk extends AsyncThunkAction<any, any, any>>(thunk: TThunk): ReturnType<TThunk>;

<ReturnType = any, State = any, ExtraThunkArg = any>(
thunkAction: ThunkAction<ReturnType, State, ExtraThunkArg, A>,
): ReturnType;
}
}
60 changes: 60 additions & 0 deletions suite-native/module-trading/src/tradingSlice.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
import { PayloadAction } from '@reduxjs/toolkit';

import { createSliceWithExtraDeps, createWeakMapSelector } from '@suite-common/redux-utils';
import {
TradingBuyState as CommonTradingBuyState,
TradingState as CommonTradingState,
initialState as commonInitialState,
prepareTradingReducer,
} from '@suite-common/trading';

import { ReceiveAccount } from './types';

export interface TradingBuyState extends CommonTradingBuyState {
selectedReceiveAccount: ReceiveAccount | undefined;
}

export interface TradingState extends CommonTradingState {
buy: TradingBuyState;
}

export type TradingRootState = {
wallet: {
trading: TradingState;
};
};

export const initialState: TradingState = {
...commonInitialState,
buy: { ...commonInitialState.buy, selectedReceiveAccount: undefined },
};

export const tradingSlice = createSliceWithExtraDeps({
name: 'trading',
initialState,
reducers: {
setBuySelectedReceiveAccount: (
state,
{ payload }: PayloadAction<{ selectedReceiveAccount: ReceiveAccount | undefined }>,
) => {
state.buy.selectedReceiveAccount = payload.selectedReceiveAccount;
},
},
extraReducers: (builder, extra) => {
const commonTradingFormReducer = prepareTradingReducer(extra);
builder
// In case that this reducer does not match the action, try to handle it by suite-common tradingReducer.
.addDefaultCase((state, action) => {
commonTradingFormReducer(state, action);
});
},
});

export const { setBuySelectedReceiveAccount } = tradingSlice.actions;

export const createMemoizedSelector = createWeakMapSelector.withTypes<TradingRootState>();

export const selectTradingBuy = (state: TradingRootState) => state.wallet.trading.buy;

export const selectBuySelectedReceiveAccount = (state: TradingRootState) =>
selectTradingBuy(state).selectedReceiveAccount;
2 changes: 2 additions & 0 deletions suite-native/state/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"@suite-common/test-utils": "workspace:*",
"@suite-common/toast-notifications": "workspace:*",
"@suite-common/token-definitions": "workspace:*",
"@suite-common/trading": "workspace:*",
"@suite-common/wallet-core": "workspace:*",
"@suite-native/blockchain": "workspace:*",
"@suite-native/device": "workspace:*",
Expand All @@ -30,6 +31,7 @@
"@suite-native/graph": "workspace:*",
"@suite-native/message-system": "workspace:*",
"@suite-native/module-send": "workspace:*",
"@suite-native/module-trading": "workspace:*",
"@suite-native/settings": "workspace:*",
"@suite-native/storage": "workspace:*",
"@trezor/transport-native-usb": "workspace:*",
Expand Down
11 changes: 11 additions & 0 deletions suite-native/state/redux.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { AsyncThunkAction } from '@reduxjs/toolkit';

declare module 'redux' {
export interface Dispatch<A extends Action = AnyAction> {
<TThunk extends AsyncThunkAction<any, any, any>>(thunk: TThunk): ReturnType<TThunk>;

<ReturnType = any, State = any, ExtraThunkArg = any>(
thunkAction: ThunkAction<ReturnType, State, ExtraThunkArg, A>,
): ReturnType;
}
}
3 changes: 3 additions & 0 deletions suite-native/state/src/reducers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import { featureFlagsPersistedKeys, featureFlagsReducer } from '@suite-native/fe
import { nativeFirmwareReducer } from '@suite-native/firmware';
import { graphPersistTransform, graphReducer } from '@suite-native/graph';
import { sendFormSlice } from '@suite-native/module-send';
import { tradingSlice } from '@suite-native/module-trading';
import { appSettingsPersistWhitelist, appSettingsReducer } from '@suite-native/settings';
import {
deriveAccountTypeFromPaymentType,
Expand Down Expand Up @@ -59,6 +60,7 @@ const deviceReducer = prepareDeviceReducer(extraDependencies);
const discoveryReducer = prepareDiscoveryReducer(extraDependencies);
const tokenDefinitionsReducer = prepareTokenDefinitionsReducer(extraDependencies);
const sendFormReducer = sendFormSlice.prepareReducer(extraDependencies);
const tradingReducer = tradingSlice.prepareReducer(extraDependencies);
const stakeReducer = prepareStakeReducer(extraDependencies);
const firmwareReducer = prepareFirmwareReducer(extraDependencies);

Expand All @@ -82,6 +84,7 @@ export const prepareRootReducers = async () => {
send: sendFormReducer,
fees: feesReducer,
stake: stakeReducer,
trading: tradingReducer,
});

const walletPersistedReducer = await preparePersistReducer({
Expand Down
2 changes: 2 additions & 0 deletions suite-native/state/src/store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { Middleware, StoreEnhancer, configureStore } from '@reduxjs/toolkit';
import devToolsEnhancer from 'redux-devtools-expo-dev-plugin';
import { logger } from 'redux-logger';

import { tradingMiddleware } from '@suite-common/trading';
import { prepareFiatRatesMiddleware } from '@suite-common/wallet-core';
import { blockchainMiddleware } from '@suite-native/blockchain';
import { prepareButtonRequestMiddleware, prepareDeviceMiddleware } from '@suite-native/device';
Expand All @@ -25,6 +26,7 @@ const middlewares: Middleware[] = [
prepareButtonRequestMiddleware(extraDependencies),
prepareDiscoveryMiddleware(extraDependencies),
sendFormMiddleware,
tradingMiddleware,
];

const enhancers: Array<StoreEnhancer<any, any>> = [];
Expand Down
4 changes: 4 additions & 0 deletions suite-native/state/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
{
"path": "../../suite-common/token-definitions"
},
{
"path": "../../suite-common/trading"
},
{
"path": "../../suite-common/wallet-core"
},
Expand All @@ -34,6 +37,7 @@
{ "path": "../graph" },
{ "path": "../message-system" },
{ "path": "../module-send" },
{ "path": "../module-trading" },
{ "path": "../settings" },
{ "path": "../storage" },
{
Expand Down
2 changes: 2 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -11097,6 +11097,7 @@ __metadata:
"@suite-common/test-utils": "workspace:*"
"@suite-common/toast-notifications": "workspace:*"
"@suite-common/token-definitions": "workspace:*"
"@suite-common/trading": "workspace:*"
"@suite-common/wallet-core": "workspace:*"
"@suite-native/blockchain": "workspace:*"
"@suite-native/device": "workspace:*"
Expand All @@ -11107,6 +11108,7 @@ __metadata:
"@suite-native/graph": "workspace:*"
"@suite-native/message-system": "workspace:*"
"@suite-native/module-send": "workspace:*"
"@suite-native/module-trading": "workspace:*"
"@suite-native/settings": "workspace:*"
"@suite-native/storage": "workspace:*"
"@trezor/transport-native-usb": "workspace:*"
Expand Down
Loading