Tighten Dispatch type - HELP WANTED #17204
Draft
+43
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komret
requested review from
szymonlesisz,
marekrjpolak,
mroz22 and
peter-sanderson
|
🚀 Expo preview is ready!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to tighten
Dispatchtype so that it provides some type security to our actions, preventing bugs like this one.1st commit changes the
Dispatchtype and fixes code wherever I more or less knew what to do.2nd commit skips type check for lines that I couldn't fix - HELP WANTED.
3rd commit skips type check for metadata-related types which seem to be the biggest offender and I also couldn't fix them properly - HELP WANTED, I know @mroz22 is knowledgable about these.