Sacado/ShyLU: Upgrade to Googletest v16 #13849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is exactly what I did: ``` cd packages/sacado/test/GTestSuite wget https://github.com/google/googletest/archive/refs/tags/v1.16.0.tar.gz tar -xzf v1.16.0.tar.gz rm -rf googletest mv googletest-1.16.0 googletest ``` Signed-off-by: Samuel E. Browne <[email protected]>
Two main differences: 1. Rename `gtest` target to `sacado-gtest` to avoid name collisions 2. Set `gtest_SOURCE_DIR`. Seems to be a bug in googletest, but not 100% sure. Otherwise will get compile errors in gtest, and possible downstream compile errors about type issues within function calls to gtest. Signed-off-by: Samuel E. Browne <[email protected]>
What we _should_ do is to extract this to an included TPL type thing (I believe in the past we tried to put it in commonTools), but that's more work. This is better than it was, as long as the symbolic link doesn't cause issues on any certain types of builds (e.g. Windows). Signed-off-by: Samuel E. Browne <[email protected]>
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Failure: Job PR_aue_srn_at1 on Jenkins server at https://do.sandia.gov/trilinos-ci Does Not Exist
|
sebrowne
added
the
AT: RETEST
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_aue_srn_at1
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: sebrowne |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/sacado
@trilinos/shylu
Motivation
There are configure warnings from the (old) Googletest in Sacado in some CI builds. Want to clean these up where possible to keep our dashboards as relevant as possible.
Testing
I configured, built, and ran the tests for the two packages in question with GCC + OpenMPI.
Additional Information
I pointed the source from ShyLU_NodeTacho into the Sacado snapshot via a symlink to avoid duplication and save repository space. Also of note, I split the commits up such that the modifications to Googletest that are needed to put it into Trilinos are very explicit and obvious.