Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Health Checks section in installation readme #567

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

andythsu
Copy link
Member

@andythsu andythsu commented Dec 6, 2024

Description

Fix the wording in Health Checks section to avoid confusion

Additional context and related issues

https://trinodb.slack.com/archives/C059KUNPTSP/p1733245765766909

Release notes

(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Dec 6, 2024
@andythsu andythsu requested a review from mosabua December 6, 2024 02:25
Copy link
Member

@Chaho12 Chaho12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix

  • wrapping at 80 chars column
  • avoid future tense (no "will")
  • dont use "trino gateway" .. lower case
  • Dont use "Please"
  • Link just with (routing-rules.. no ./
  • Maybe document the statuses better if needed

@andythsu
Copy link
Member Author

andythsu commented Dec 9, 2024

Can you fix

  • wrapping at 80 chars column
  • avoid future tense (no "will")
  • dont use "trino gateway" .. lower case
  • Dont use "Please"
  • Link just with (routing-rules.. no ./
  • Maybe document the statuses better if needed

fixed.

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you @andythsu !

@mosabua mosabua merged commit f4b78f4 into trinodb:main Dec 9, 2024
1 check passed
@github-actions github-actions bot added this to the 14 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants