Display cluster health status on cluster page #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice usability improvement! |
|
Could you add another screenshot with dark theme to PR description? |
Thanks @ebyhr , done. |
mosabua
reviewed
Jan 28, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/resource/GatewayWebAppResource.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Jan 29, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/resource/GatewayWebAppResource.java
Outdated
Show resolved
Hide resolved
mosabua
reviewed
Jan 29, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/TrinoStatus.java
Outdated
Show resolved
Hide resolved
mosabua
reviewed
Jan 29, 2025
mosabua
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
I think this looks good now. Any further comments or suggestions before we merge @ebyhr @willmostly ?
|
If we really need another adjustment we can do a follow up PR. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display cluster health status on the cluster page
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: