misc:update our travis config so it passes with external contributor PRs

.travis.yml

@@ -23,17 +23,27 @@ env:
   # encrypted GH_TOKEN:
   - secure: N551P94nYNIuv5IIcvgtee/jfd9ReGYRbq5hUvgG1pRbb+8wtNWT9JM6qIUflj0GoVCDeuz+urvqFwC4OET/NC6sGB9rtVoAVjf7vfKaoxPTN2wSMjT8GcVXvnG6S5hdPO6JlVrXZf2kDJr8p0vWKgRTgU7hSfEr8Nuxk938MC+qLUpuS6oAx0Vekkq/05OrZMIiheqHpSbXZido1SWBEy+XdL1MpNpKYSnp4gQXxtOQkF28vHQMKVDvPNoPm0RpuYmab6kJnGXDkWIsBtZlknw+Wf0oK9LJRuV8jFD4rkxRthuYDAXiep3dY8bkCZzo80Sy/KEB2oYKvMSBNDYlBoYeR3hsv5OB8ujhCDoXdBddjhIEe9vIFV93QWVzE+XCCfG1IczhTQ57Pk33eGfvRv/QnGnXKdSqS2+4roXOfohFh98oRzKGsFhjZ+22QQkyBHwcghw5xywPcr8ZF0ZC06pF7hvCFIlubDz9ZAaQo7vkpXbbft34ooxpGvSgQ5JOUXMu/zDy1E+szXwgcCn5trXhPEUhznCKiC2qrR4q1mVzyspXOHxz7hXkthWqUZEKFWrJw3/ttSZd1qQ7HFv2Re1eEIA/Q0HpCMe4Php5oqRDsxA7zUIHpw19aqtAhCR4WNg8yY7OmGXp3VeUQ3aiS/fFBbbsYRFj62Fv4Hr5BJY=
 before_install:
-- if [ "$TRAVIS_OS_NAME" = "osx" ]; then
+  # Only mess with encryption if we might be publishing (don't set up keychain for PRs)
+- if [ "$TRAVIS_OS_NAME" = "osx" ] && [ "$TRAVIS_SECURE_ENV_VARS" = "true" ] && [ "$TRAVIS_PULL_REQUEST" = "false" ]; then
+    echo "Configuring keychain...";
     export CSC_IDENTITY_AUTO_DISCOVERY=false;
     export CSC_LINK=certs/osx.p12;
     openssl aes-256-cbc -K $encrypted_7777a4e0a460_key -iv $encrypted_7777a4e0a460_iv -in certs/osx.p12.enc -out $CSC_LINK -d;
 
     export KEYCHAIN=build.keychain;
-    security create-keychain -p mysecretpassword $KEYCHAIN;
-    security default-keychain -s $KEYCHAIN;
-    security unlock-keychain -p mysecretpassword $KEYCHAIN;
-    security import $CSC_LINK -k $KEYCHAIN -P $CSC_KEY_PASSWORD -T /usr/bin/codesign;
-    security set-key-partition-list -S "apple-tool:,apple:,codesign:" -s -k mysecretpassword $KEYCHAIN;
+    export KEYCHAIN_PASS=$RANDOM.$RANDOM.$RANDOM;
+    security -q create-keychain -p $KEYCHAIN_PASS $KEYCHAIN >/dev/null 2>&1;
+    security -q default-keychain -s $KEYCHAIN >/dev/null 2>&1;
+    security -q unlock-keychain -p $KEYCHAIN_PASS $KEYCHAIN >/dev/null 2>&1;
+    security -q import $CSC_LINK -k $KEYCHAIN -P $CSC_KEY_PASSWORD -T /usr/bin/codesign >/dev/null 2>&1;
+    security -q set-key-partition-list -S "apple-tool:,apple:,codesign:" -s -k $KEYCHAIN_PASS $KEYCHAIN >/dev/null 2>&1;
+
+    rm $CSC_LINK;
+    unset KEYCHAIN_PASS;
+    unset KEYCHAIN;
+    unset CSC_KEY_PASSWORD;
+    unset CSC_LINK;
+    unset CSC_IDENTITY_AUTO_DISCOVERY;
   fi
 script:
 - if [ "$TRAVIS_OS_NAME" = "linux" ]; then npm run build-linux; fi