This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix:make events display again #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
changed the title
|
@haltman-at (added you as reviewer here, if you get the chance, to verify that the encoding logic is sufficiently correct) |
haltman-at
approved these changes
Aug 23, 2019
nicholasjpaterno
approved these changes
Aug 23, 2019
davidmurdoch
added a commit
that referenced
this pull request
Aug 28, 2019
This was referenced Jan 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contract events weren't showing up for users of
[email protected]and higher due to a commit that removed the event's signature from migrated contract abis: trufflesuite/truffle#1949This PR fixes this issue by creating the event signature locally if it isn't already supplied in the abi.
Fixes #1293