This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
improvement: bump ethereumjs-wallet #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull-request upgrades `ethereumjs-wallet`, which has upgraded the underlying dependency on scrypt.js to 0.3.0, making scrypt an optional dependency and offering a pure JS version as a fallback. The reasoning behind this is that scrypt is problematic to install in some systems, particularly those that don't have node-gyp setup and we have seen some weird issues when installing with elevated privileges (i.e. `sudo npm install -g scrypt`) This change would also require following up with bumping all dependencies on `ganache-core` to use the latest version too, which I can do as well.
|
Huh, not sure if the CI failure is related to my change. Edit: Turns out the same is happening in #419, so I'm pretty sure it's unrelated. |
|
This looks great! Thanks! I'll bump ganache and ganache-cli when the next ganache-core version is released. truffle will do the same shortly after that. Thanks again! |
|
The CI failure is due to the transitive dependency |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request upgrades
ethereumjs-wallet, which has upgraded the underlying dependency on scrypt.js to 0.3.0, making scrypt an optional dependency and offering a pure JS version as a fallback.The reasoning behind this is that scrypt is problematic to install in some systems, particularly those that don't have node-gyp setup and we have seen some weird issues when installing with elevated privileges (i.e.
sudo npm install -g scrypt)This change would also require following up with bumping all dependencies on
ganache-coreto use the latest version too, which I can do as well.cc. @iurimatias @michaelsbradleyjr