This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Skip getting contract node if there's no AST #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue that was reported over on the Ganache repo. The problem appears to be that Ganache passes all contracts in to the contract decoder as relevant contracts, even ones that aren't Solidity. These don't have an AST, and, as such, cause an error when we try to find their contract node. So, I've changed the code for getting the contract nodes so it will skip any lacking an AST (or that have an AST but can't find the contract node for whatever reason).