Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add additional operations only after batch write succeeds #698

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

bstasyszyn
Copy link
Contributor

closes #697

@cla-bot cla-bot bot added the cla-signed label Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (41b2f35) 93.95% compared to head (2a8740b) 93.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #698   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files          79       79           
  Lines        4497     4499    +2     
=======================================
+ Hits         4225     4227    +2     
  Misses        154      154           
  Partials      118      118           
Impacted Files Coverage Δ
pkg/batch/writer.go 91.26% <75.00%> (+0.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fqutishat fqutishat merged commit 3c7387f into trustbloc:main Jun 6, 2023
@bstasyszyn bstasyszyn deleted the 697 branch June 6, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed processing of batch can cause operation queue to grow uncontrollably
2 participants