Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): add aws_elasticache_update_action #2431

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fyqtian
Copy link

@fyqtian fyqtian commented Feb 25, 2025

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
 cache_cluster_id                         | replication_group_id            | engine    | estimated_update_time | nodes_updated | service_update_name                                  | service_update_recommended_apply_by_date | service_update_release_date | service_update_severi>
+------------------------------------------+---------------------------------+-----------+-----------------------+---------------+------------------------------------------------------+------------------------------------------+-----------------------------+---------------------->
| <null>                                   | xxxxxxxxxxxxxx                  | redis     | 30 minutes per node   | 0/2           | elasticache-patch-update-202501                      | 2025-02-05T18:59:59+08:00                | 2025-01-06T19:00:00+08:00   | important            >
| <null>                                   | xxxxxxxxxxxxxx                  | redis     | 30 minutes per node   | 0/3           | elasticache-patch-update-2-202501                    | 2025-02-10T17:59:59+08:00                | 2025-01-11T18:00:00+08:00   | important            >
| <null>                                   | xxxxxxxxxxxxxx                  | redis     | 30 minutes per node   | 0/2           | elasticache-patch-update-2-202501                    | 2025-02-10T17:59:59+08:00                | 2025-01-11T18:00:00+08:00   | important            >
| xxxxxxxxxxxxxx                           | <null>                          | redis     | 30 minutes per node   | 0/1           | elasticache-patch-update-202501                      | 2025-02-05T18:59:59+08:00                | 2025-01-06T19:00:00+08:00   | important            >
| <null>                                   | xxxxxxxxxxxxxx                  | redis     | 30 minutes per node   | 0/2           | elasticache-patch-update-2-202501                    | 2025-02-10T17:59:59+08:00                | 2025-01-11T18:00:00+08:00   | important            >
| <null>                                   | xxxxxxxxxxxxxx                  | redis     | 30 minutes per node   | 0/1           | elasticache-patch-update-2-202501                    | 2025-02-10T17:59:59+08:00                | 2025-01-11T18:00:00+08:00   | important            >

@ParthaI
Copy link
Contributor

ParthaI commented Feb 25, 2025

Hi @fyqtian, great to see the PR! Could you please address the same review comments that were provided in your other PR (#2430) as well?

@@ -217,7 +221,13 @@ func tableAwsElastiCacheCluster(_ context.Context) *plugin.Table {
Hydrate: listTagsForElastiCacheCluster,
Transform: transform.FromField("TagList"),
},

{
Name: "update_actions",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this column, now that we have a separate table for it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest removing this column, as we don't generally want to include paginated requests in non-List columns (see Hydrate function pagination in https://steampipe.io/docs/develop/plugin-release-checklist#data-ingestion)

@ParthaI ParthaI linked an issue Feb 25, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add table aws_elasticache_update_actions
3 participants