udf: fix memory leak for libsql_wasm_engine_new #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The leak was quite obvious - there was no destructor for the per-connection Wasm engine.
psarna
added a commit
to psarna/sqld
that referenced
this pull request
May 19, 2023
github-merge-queue bot
pushed a commit
to libsql/sqld
that referenced
this pull request
May 22, 2023
MarinPostma
added a commit
that referenced
this pull request
Oct 17, 2023
72: wal file improvements r=MarinPostma a=MarinPostma
this PR introduces some overall improvements to our custom WAL file format.
- The WAL file header is improved to contain more informartion:
- the database UUID that the log is replicating
- Fields like initial checksum, start_frame_index for log compaction
- a magic number
- Each WAL frame is now preceded by a `WalFrameHeader`, that contains:
- The running checksum of the pages, including the current page.
- The id of the start_frame_index
- the page_no of the of the page contained in the frame
- size_after: 0 on non-commit frame, otherwise, equal to the size (in page), of the database after applying those frames. (passed to and from the `xFrame` call).
- Use of Zerocopy to serialize and deserialize frames
169: proto: encode uuid as string r=MarinPostma a=MarinPostma
191: Revert "Revert "fix db path"" r=MarinPostma a=MarinPostma
Reverts libsql/sqld#184
192: .gitignore: ignore the new data directory r=psarna a=psarna
./data.sqld/ directory is runtime-only, so let's ignore it.
Co-authored-by: ad hoc <[email protected]>
Co-authored-by: Piotr Sarna <[email protected]>
MarinPostma
pushed a commit
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leak was quite obvious - there was no destructor for the per-connection Wasm engine.