crates/core: add ValueRef and Column #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
reviewed
Jul 27, 2023
| Null, | ||
| Integer(i64), | ||
| Real(f64), | ||
| Text(&'a [u8]), |
There was a problem hiding this comment.
Minor but we could leave this as a str to keep the enforced utf8 since its trivial to convert back into a u8.
There was a problem hiding this comment.
fair enough, rusqlite was like that probably mostly to satisfy weird windows encodings, but we're more opinionated on that front
LucioFranco
approved these changes
Jul 27, 2023
MarinPostma
pushed a commit
that referenced
this pull request
Oct 17, 2023
235: Hrana server authentication r=honzasp a=honzasp Implement authentication in Hrana using JWTs. An Ed25519 public key is passed to sqld using `--hrana-jwt-key-file`, and the received JWT is verified using this key. We ignore the claims, except by validating the expiration in `exp`. I also added a helper script `scripts/gen_jwt.py` to generate the key and a JWT. This PR is stacked on top of #231. Co-authored-by: Jan Špaček <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now, since I'm actively working on migrating sqld on top of the new interfaces. Only once both work, I'll proceed with this PR.