libsql/replication: Switch to BatchLogEntries RPC #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LogEntries RPC is stream-based, which doesn't really work for the `sync()` API we have. Switch to the new BatchLogEntries RPC introduced by Lucio.
psarna
approved these changes
Aug 8, 2023
psarna
reviewed
Aug 8, 2023
| .and_then(|f| Frame::try_from_bytes(f.data.into())) | ||
| let frames = frames.frames.iter() | ||
| .map(|f| { | ||
| Frame::try_from_bytes(f.data.clone()) |
There was a problem hiding this comment.
An unfortunate clone()... would it help if you called frames.frames.into_iter() instead of frames.frames.iter(), to own the iterated values?
MarinPostma
pushed a commit
that referenced
this pull request
Oct 17, 2023
253: Replace an expired JWT in tests r=honzasp a=honzasp The previous JWT expired in 3 days, breaking tests. The new one should expire in 2123, when we should no longer be around! Co-authored-by: Jan Špaček <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LogEntries RPC is stream-based, which doesn't really work for the
sync()API we have. Switch to the new BatchLogEntries RPC introduced by Lucio.